suppressed Integer annotation on Factorization; fixed bug in calls of… #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppressed the annotations
<:Integer
on theT
ofFactorization
, allowingPrimes.Factorization
to be used to hold factorizations of other than integer (my goal is for polynomials). I added tests inruntest.jl
whereT
isSymbol
.Along the way, I fixed bugs in the calls to
searchsortedfirst
. In the callsearchsortedfirst(f.pe, p, by=first)
contrary to intuition, the functionby
is applied top
so the proper second argument should be a pair. This does not show forp
integer since thenfirst(p)==p
but it shows for other types. The fix is to give a pair:searchsortedfirst(f.pe, p=>0, by=first)