Restrict scalar indexing to Numbers #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Interpolations to exploit Julia's abstract indexing
rules, which will give us things like
itp[linspace(1,10,1001), linspace(1,15,201)]
for free.
|
LGTM! Thanks for taking the time! :) When the Julia PR merges, we might want to add a couple of sanity tests for this, too. Referencing #48 here too, for completeness. |
timholy
added a commit
that referenced
this pull request
Aug 6, 2015
Restrict scalar indexing to Numbers
Ah, right; I should have waited to hit merge. I'll file an issue to remind myself. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us exploit Julia's new indexing utilities.
For the
linspacething to work, it will require a to-be-submitted julia PR, to which I'll link shortly.