Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag 1.0? #136

Closed
stevengj opened this issue Jun 8, 2020 · 4 comments
Closed

tag 1.0? #136

stevengj opened this issue Jun 8, 2020 · 4 comments

Comments

@stevengj
Copy link
Member

stevengj commented Jun 8, 2020

Pre-1.0 versions are painful for packages to declare compatibility with, since every minor version bump is assumed to be breaking.

Are there any breaking changes planned on the horizon that I'm forgetting about, or should we go ahead and tag 1.0?

cc @jmkuhn, @quinnj

@jmkuhn
Copy link
Contributor

jmkuhn commented Jun 8, 2020

I do plan to change sigexp() and export it, but since it isn't currently exported or documented I wouldn't consider this a breaking change.

Ideally I would like to have ARM working before tagging 1.0 but I can't promise this quickly. I don't have any objection to tagging 1.0.

@stevengj
Copy link
Member Author

stevengj commented Jun 9, 2020

Since both of those changes are non-breaking, they can be made in 1.x, so they don't need to hold up a 1.0 release.

However, it wouldn't hurt to change the sigexp API first to the version that we want to export eventually.

@jmkuhn
Copy link
Contributor

jmkuhn commented Jun 11, 2020

I'll add sigexp, randn, and randexp so we won't have to immediately tag 1.1 for these new features. Everything else I have planned is a bug fix.

@stevengj
Copy link
Member Author

I tagged 1.0 (JuliaRegistries/General#16483) now that we have sigexp, since this changed the API (albeit the old one was internal). Tagging 1.1 for randn etcetera is not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants