-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cancellation of common variables in 'simplify' #24
base: master
Are you sure you want to change the base?
Conversation
These simplifications breaks matrix algebra. |
Ivar, I tested it only on simple expressions. Can you give some matrix example that breaks after this commit? |
If you have a matrix in the denumerator, you can not shorten it by this kind of simple elimination. Sometimes you will end up with an identity matrix |
So this is because |
Yes, it is because (users of) julia does not follow its basic API design principle for For |
Because I'm traveling I won't have time to think a lot about this, but I had never intended for these symbolic operations to work on matrices, just real numbers. If we can make them more general, that would be great. I think it would be very helpful to discuss this issue on the julia-users mailing list, specifically asking for feedback from Stefan, Viral, Steven Johnson and Alan Edelman. |
I think we should restrict to real numbers only.
|
No description provided.