Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjoint overload for ::Function is type piracy #133

Closed
tkoolen opened this issue Jul 15, 2019 · 0 comments · Fixed by #136
Closed

Adjoint overload for ::Function is type piracy #133

tkoolen opened this issue Jul 15, 2019 · 0 comments · Fixed by #136

Comments

@tkoolen
Copy link

tkoolen commented Jul 15, 2019

Calculus.jl/src/derivative.jl

Lines 32 to 36 in 4da2f9b

if isdefined(Base, :adjoint)
Base.adjoint(f::Function) = derivative(f)
else
Base.ctranspose(f::Function) = derivative(f)
end

Is type piracy. Zygote is now similarly committing type piracy (FluxML/Zygote.jl#260), leading to warnings like

WARNING: Method definition adjoint(Function) in module Zygote at /home/twan/.julia/packages/Zygote/fuj2C/src/compiler/interface.jl:50 overwritten in module Calculus at /home/twan/.julia/packages/Calculus/2qBLt/src/derivative.jl:33.
@tkoolen tkoolen mentioned this issue Jul 15, 2019
Open
@tkoolen tkoolen changed the title Adjoint overload for ::function is type piracy Adjoint overload for ::Function is type piracy Jul 15, 2019
@tkoolen tkoolen mentioned this issue Jul 15, 2019
Merged
This was referenced Jul 16, 2019
Closed
Merged
This was referenced Mar 11, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove adjoint overload ChrisRackauckas/Calculus.jl
1 participant
@tkoolen