You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Progress type has a fraction field, and I am considering an alternative that stores two quantities e.g. completed and total, which conceptually are just the numerator and denominator of the fraction.
Having that structure, however, allows the denominator to take on a sentinel value (perhaps 0, perhaps -1, perhaps missing) in order to log progress on tasks with an unknown amount of steps.
I think it's a worthwhile idea to explore.
The Progress type could acquire additional fields, and keep the fraction field redundantly.
This would keep e.g. VSCodeServer working.
Furthermore, VSCodeServer.jl vendors JSON.jl, so avoiding the redundant information would require a modification to VSCodeServer.jl itself. I think that's the winning solution, but perhaps there's an alternative that I am missing.
The
Progress
type has afraction
field, and I am considering an alternative that stores two quantities e.g. completed and total, which conceptually are just the numerator and denominator of the fraction.Having that structure, however, allows the denominator to take on a sentinel value (perhaps
0
, perhaps-1
, perhapsmissing
) in order to log progress on tasks with an unknown amount of steps.I think it's a worthwhile idea to explore.
The
Progress
type could acquire additional fields, and keep thefraction
field redundantly.This would keep e.g. VSCodeServer working.
I would prefer not keeping this redundant information, but the default behavior for serializing the object is based on
fieldnames
notpropertynames
: https://github.com/JuliaIO/JSON.jl/blob/4b3913d58f04cc5bb2f8d23c6ef82e0fbed20525/src/Writer.jl#L23Furthermore, VSCodeServer.jl vendors JSON.jl, so avoiding the redundant information would require a modification to VSCodeServer.jl itself. I think that's the winning solution, but perhaps there's an alternative that I am missing.
Related: #27 (comment)
The text was updated successfully, but these errors were encountered: