Revert "Restrict COFF to a single thread when symbol count is high (#50874)" #59736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
added
backport 1.11
Member
|
So, with this reversion, PackageCompiler will have a new GCC version requirement (GCC 11+), right? Does that requirement only apply to Windows, or does it also apply to Linux and maCOS? |
Member
Author
Yes - slightly older might be OK too, but GCC 8 is definitely not supported. It spits out: when used on Julia 1.11+ (JuliaLang/PackageCompiler.jl#918)
It should only apply to Windows / COFF (where we rely on these directives) |
…50874)" This reverts commit eb4416b. As of LLVM 16, we automatically emit: .drectve `-exclude-symbols:"<symbol>"` which mitigates this issue where it is supported by the linker (which is the case for at least GCC 11+ and LLD 14+). PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+
topolarity
force-pushed
the
ct/revert-50874
branch
from
662ba14 to
a3fd784
Compare
Member
|
SGTM. We bundle the gcc on Windows. In theory people could override with their own gcc, so in theory we should document the Windows-specfici gcc 11+ requirement somewhere. But most people will use the bundled gcc on Windows, so it's not super pressing to add the docs. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2025
…50874)" (#59736) This reverts commit eb4416b. As of LLVM 16, we automatically emit: ``` .drectve `-exclude-symbols:"<symbol>"` ``` which mitigates this issue where it is supported by the linker (GCC 11+ and LLD 14+ are tested working) PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+ (cherry picked from commit 1cba9c2)
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
…50874)" (#59736) This reverts commit eb4416b. As of LLVM 16, we automatically emit: ``` .drectve `-exclude-symbols:"<symbol>"` ``` which mitigates this issue where it is supported by the linker (GCC 11+ and LLD 14+ are tested working) PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+ (cherry picked from commit 1cba9c2)
KristofferC
pushed a commit
that referenced
this pull request
Oct 14, 2025
…50874)" (#59736) This reverts commit eb4416b. As of LLVM 16, we automatically emit: ``` .drectve `-exclude-symbols:"<symbol>"` ``` which mitigates this issue where it is supported by the linker (GCC 11+ and LLD 14+ are tested working) PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+ (cherry picked from commit 1cba9c2)
KristofferC
removed
the
backport 1.12
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit eb4416b.
As of LLVM 16, we automatically emit:
which mitigates this issue where it is supported by the linker (GCC 11+ and LLD 14+ are tested working)
PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+