Improve char to int parsing, and add tryparse method
#59603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark:
```
julia> s = [rand('0':'9') for i in 1:100000];
julia> function foo(s)
n = 0
for i in s
n += parse(Int, i)
end
n
end
```
Before: 196 us
After: 39 us
|
Oi, you've sniped me! (just kidding, improvement is nice to see) |
jakobnissen
changed the title
tryparse method
|
Test failures are unrelated |
|
Comment on lines
+41
to
+45
| @noinline function _invalid_base(base) | ||
| throw(ArgumentError("invalid base: base must be 2 ≤ base ≤ 62, got $base")) | ||
| end | ||
|
|
||
| @noinline _invalid_digit(base, char) = throw(ArgumentError("invalid base $base digit $(repr(char))")) |
There was a problem hiding this comment.
These are weirdly inconsistent?
There was a problem hiding this comment.
One is longer than the other, and therefore the line needs to be broken up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was orignially a larger PR, but I've shelved the larger refactoring for now.
This PR does two things:
tryparse(::Type{T}, c::AbstractChar; base::Integer=10) where {T <: Integer}which was previously missing