Skip to content

follow-up to hashing BigInts; expand testing #58714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025

Conversation

adienes
Copy link
Member

@adienes adienes commented Jun 11, 2025

fixes #58711
closes #58712

Copy link

Hello! I am a bot.

Thank you for your pull request!

I have assigned @LilithHafner to this pull request.

@LilithHafner can either choose to review this pull request themselves, or they can choose to find someone else to review this pull request.

Note: If you are a Julia committer, please make sure that your organization membership is public.

@LilithHafner
Copy link
Member

@oscardssmith, can you take this?

@jmkuhn
Copy link
Contributor

jmkuhn commented Jun 11, 2025

This fixes the issue I was seeing. Thanks for the quick fix.

@oscardssmith oscardssmith added bugfix This change fixes an existing bug bignums BigInt and BigFloat hashing labels Jun 11, 2025
@oscardssmith
Copy link
Member

LGTM

@LilithHafner LilithHafner merged commit c0ecfe9 into JuliaLang:master Jun 11, 2025
9 of 11 checks passed
nilesh646 pushed a commit to nilesh646/julia that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bignums BigInt and BigFloat bugfix This change fixes an existing bug hashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigInt hashing broken
4 participants