Revert "Integer can be hashed rapidly as well"
#58712
Closed
+39
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a970e16.
|
Hello! I am a bot. Thank you for your pull request! I have assigned
Note: If you are a Julia committer, please make sure that your organization membership is public. |
|
in particular, it was c2f4dd3 (added during the review process) which broke. the PR was good otherwise. but I'd prefer to keep the performance improvements from that commit, if possible, so I'm going to try to fix it rather than just revert that commit. maybe give me till EOD and if I don't get a PR up by then merge this revert? |
qinsoon
pushed a commit
to qinsoon/julia
that referenced
this pull request
Jun 12, 2025
nilesh646
pushed a commit
to nilesh646/julia
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #58440, pending more tests that will need to be added (yay coverage increasing)
ref #58711
@oscardssmith
one of these days I'll manage to not break things.