improve isdefined precision for 0 field types #58220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 24, 2025
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
JeffBezanson
approved these changes
Apr 24, 2025
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
vtjnash
reviewed
Apr 25, 2025
nsajko
reviewed
Apr 25, 2025
vtjnash
reviewed
Apr 25, 2025
| @@ -450,6 +450,10 @@ end | |||
| return Const(true) | |||
| end | |||
| end | |||
| # datatype_fieldcount is what `fieldcount` uses internally | |||
| # and returns nothing (!==0) for non-definite field counts. | |||
| elseif datatype_fieldcount(a1) === 0 | |||
There was a problem hiding this comment.
That comment seems to be false still, as it throws when given a NamedTuple:
julia> Base.datatype_fieldcount(NamedTuple{<:Any, Tuple}.body)
ERROR: ArgumentError: type does not have a definite number of fields
Stacktrace:
[1] fieldcount
@ ./runtime_internals.jl:1155 [inlined]
[2] datatype_fieldcount(t::DataType)
@ Base ./runtime_internals.jl:1119
[3] top-level scope
@ REPL[5]:1
There was a problem hiding this comment.
That looks like a bug in datatype_fieldcount; the intent seems to be for it not to throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternate to #58214.