More efficient chomp for String #58192
Open
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can avoid all the computation of valid indices for this simple function, since it only strips CR (0xD) and LF (0xA), which are known to be single bytes. This is approximately four times faster.
|
CI failure is unrelated. |
oscardssmith
approved these changes
Apr 22, 2025
|
Maybe it could have some |
jakobnissen
removed
the
merge me
|
Added some effects, so removed the "merge me" tag since that's slightly risky. |
|
@Keno @oscardssmith Is this ready to merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can avoid all the computation of valid indices for this simple function, since it only strips CR (0xD) and LF (0xA), which are known to be single bytes. This is approximately four times faster.