Skip to content

delete redundant IteratorSize method for Slices #58050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Apr 8, 2025

Already covered as an AbstractArray subtype.

@nsajko nsajko added arrays [a, r, r, a, y, s] iteration Involves iteration or the iteration protocol labels Apr 8, 2025
Already covered as an `AbstractArray` subtype.
@nsajko nsajko force-pushed the delete_redundant_IteratorSize_method_for_Slices branch from ead3218 to 203af28 Compare April 13, 2025 10:19
@nsajko
Copy link
Contributor Author

nsajko commented Apr 13, 2025

Rebased, hoping CI is healthier now.

@nsajko
Copy link
Contributor Author

nsajko commented Apr 14, 2025

Bump? I confirm this doesn't cause any invalidation when running my usual workload (which defines a subtype of Integer and a subtype of AbstractString, both with some methods for existing functions).

@nsajko
Copy link
Contributor Author

nsajko commented Apr 14, 2025

These are the relevant type definitions, in case it helps review:

abstract type AbstractSlices{T,N} <: AbstractArray{T,N} end

struct Slices{P,SM,AX,S,N} <: AbstractSlices{S,N}

And the IteratorSize method for AbstractArray:

IteratorSize(::Type{<:AbstractArray{<:Any,N}}) where {N} = HasShape{N}()

@nsajko
Copy link
Contributor Author

nsajko commented Apr 16, 2025

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s] iteration Involves iteration or the iteration protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant