Skip to content

_precompilepkgs: interactive progress display: fix unintended capture #57932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

_precompilepkgs: interactive progress display: fix unintended capture #57932

merged 1 commit into from
Mar 31, 2025

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Mar 28, 2025 •
edited
Loading

The variable str also exists in one of the enclosing closures. Use a new variable, as was surely intended, instead of capturing and mutating the str.

Improves the sysimage's resistance to invalidation.

@nsajko nsajko added compiler:precompilation Precompilation of modules invalidations labels Mar 28, 2025
@nsajko
Copy link
Contributor Author

nsajko commented Mar 28, 2025

Some of the eliminated invalidations:

{
    "type": "Tuple{Type{Int64}, Integer}",
    "tree": {
        "method_instance": {
            "method": "nextind(s::AbstractString, i::Integer) @ Base strings/basic.jl:565",
            "method_instance": "MethodInstance for nextind(::Base.AnnotatedString{String}, ::Integer)"
        },
        "children": [
            {
                "method_instance": {
                    "method": "iterate(itr::Base.RegexMatchIterator, ::Any) @ Base regex.jl:736",
                    "method_instance": "MethodInstance for iterate(::Base.RegexMatchIterator{Base.AnnotatedString{String}}, ::Tuple{Any, Any})"
                },
                "children": [
                    {
                        "method_instance": {
                            "method": "iterate(I::Base.ANSIIterator, ::Any) @ Base show.jl:89",
                            "method_instance": "MethodInstance for iterate(::Base.ANSIIterator{Base.AnnotatedString{String}}, ::Any)"
                        },
                        "children": [
                            {
                                "method_instance": {
                                    "method": "_truncate_at_width_or_chars(ignore_ANSI::Bool, str::AbstractString, width::Int64, rpad::Bool, chars, truncmark) @ Base show.jl:97",
                                    "method_instance": "MethodInstance for Base._truncate_at_width_or_chars(::Bool, ::AbstractString, ::Int64, ::Bool, ::String, ::String)"
                                },
                                "children": [   
                                ]               
                            }
                        ]
                    }               
                ]
            }
        ]
    }
}
{
    "method_instance": {
        "method": "repeat(c::AbstractChar, r::Integer) @ Base strings/string.jl:573",
        "method_instance": "MethodInstance for repeat(::Char, ::Integer)"
    },
    "children": [
        {
            "method_instance": {
                "method": "_truncate_at_width_or_chars(ignore_ANSI::Bool, str::AbstractString, width::Int64, rpad::Bool, chars, truncmark) @ Base show.jl:97",
                "method_instance": "MethodInstance for Base._truncate_at_width_or_chars(::Bool, ::AbstractString, ::Int64, ::Bool, ::String, ::String)"
            },
            "children": [
                {
                    "method_instance": {
                        "method": "_truncate_at_width_or_chars(ignore_ANSI::Bool, str::AbstractString, width::Int64) @ Base show.jl:97",
                        "method_instance": "MethodInstance for Base._truncate_at_width_or_chars(::Bool, ::AbstractString, ::Int64)"
                    },
                    "children": [
                        {
                            "method_instance": {
                                "method": "(::Base.Precompilation.var\"#_precompilepkgs##39#_precompilepkgs##40\")(iostr) @ Base.Precompilation precompilation.jl:829",
                                "method_instance": "MethodInstance for (::Base.Precompilation.var\"#_precompilepkgs##39#_precompilepkgs##40\"{Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})(::IOBuffer)"
                            },
                            "children": [
                            ]
                        },
                        {
                            "method_instance": {
                                "method": "(::Base.Precompilation.var\"#_precompilepkgs##39#_precompilepkgs##40\")(iostr) @ Base.Precompilation precompilation.jl:829",
                                "method_instance": "MethodInstance for (::Base.Precompilation.var\"#_precompilepkgs##39#_precompilepkgs##40\"{Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})(::IOBuffer)"
                            },
                            "children": [
                                {
                                    "method_instance": {
                                        "method": "var\"#sprint#447\"(context, sizehint::Integer, ::typeof(sprint), f::Function, args...) @ Base strings/io.jl:106",
                                        "method_instance": "MethodInstance for Base.var\"#sprint#447\"(::Nothing, ::Int64, ::typeof(sprint), ::Base.Precompilation.var\"#_precompilepkgs##39#_precompilepkgs##40\"{Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})"
                                    },
                                    "children": [
                                        {
                                            "method_instance": {
                                                "method": "sprint(f::Function, args...; context, sizehint) @ Base strings/io.jl:106",
                                                "method_instance": "MethodInstance for sprint(::Base.Precompilation.var\"#_precompilepkgs##39#_precompilepkgs##40\"{Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})"
                                            },
                                            "children": [
                                                {
                                                    "method_instance": {
                                                        "method": "(::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\")() @ Base.Precompilation precompilation.jl:821",
                                                        "method_instance": "MethodInstance for (::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\"{Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})()"
                                                    },
                                                    "children": [
                                                    ]
                                                },
                                                {
                                                    "method_instance": {
                                                        "method": "(::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\")() @ Base.Precompilation precompilation.jl:821",
                                                        "method_instance": "MethodInstance for (::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\"{Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})()"
                                                    },
                                                    "children": [
                                                    ]
                                                },
                                                {
                                                    "method_instance": {
                                                        "method": "(::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\")() @ Base.Precompilation precompilation.jl:821",
                                                        "method_instance": "MethodInstance for (::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\"{Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})()"
                                                    },
                                                    "children": [
                                                        {
                                                            "method_instance": {
                                                                "method": "lock(f, l::Base.AbstractLock) @ Base lock.jl:332",
                                                                "method_instance": "MethodInstance for lock(::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\"{Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}}, ::ReentrantLock)"
                                                            },
                                                            "children": [
                                                            ]
                                                        },
                                                        {
                                                            "method_instance": {
                                                                "method": "lock(f, l::Base.AbstractLock) @ Base lock.jl:332",
                                                                "method_instance": "MethodInstance for lock(::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\"{Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}}, ::ReentrantLock)"
                                                            },
                                                            "children": [
                                                            ]
                                                        },
                                                        {
                                                            "method_instance": {
                                                                "method": "lock(f, l::Base.AbstractLock) @ Base lock.jl:332",
                                                                "method_instance": "MethodInstance for lock(::Base.Precompilation.var\"#_precompilepkgs##37#_precompilepkgs##38\"{Int64, Base.Precompilation.MiniProgressBar, Vector{String}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}}, ::ReentrantLock)"
                                                            },
                                                            "children": [
                                                                {
                                                                    "method_instance": {
                                                                        "method": "(::Base.Precompilation.var\"#_precompilepkgs##33#_precompilepkgs##34\")() @ Base.Precompilation precompilation.jl:798",
                                                                        "method_instance": "MethodInstance for (::Base.Precompilation.var\"#_precompilepkgs##33#_precompilepkgs##34\"{Bool, Vector{Pair{Cmd, Base.CacheFlags}}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Base.Event, ReentrantLock, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Dict{Base.PkgId, Vector{Base.PkgId}}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})()"
                                                                    },
                                                                    "children": [
                                                                    ]
                                                                },
                                                                {
                                                                    "method_instance": {
                                                                        "method": "(::Base.Precompilation.var\"#_precompilepkgs##33#_precompilepkgs##34\")() @ Base.Precompilation precompilation.jl:798",
                                                                        "method_instance": "MethodInstance for (::Base.Precompilation.var\"#_precompilepkgs##33#_precompilepkgs##34\"{Bool, Vector{Pair{Cmd, Base.CacheFlags}}, Bool, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Set{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, String, String, String, String, Base.Precompilation.var\"#ansi_moveup#_precompilepkgs##21\", Base.Event, Base.Event, ReentrantLock, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, String}, Vector{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Dict{Tuple{Base.PkgId, Pair{Cmd, Base.CacheFlags}}, Bool}, Vector{Base.PkgId}, Base.Precompilation.var\"#describe_pkg#_precompilepkgs##1\"{Dict{Base.PkgId, Base.PkgId}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}, Int64}, Dict{Base.PkgId, Vector{Base.PkgId}}, Base.Precompilation.var\"#color_string#_precompilepkgs##0\"{Bool}})()"
                                                                    },
                                                                    "children": [
                                                                    ]
                                                                }
                                                            ]
                                                        }
                                                    ]
                                                }
                                            ]
                                        }
                                    ]
                                }
                            ]
                        }
                    ]
                }
            ]
        }
    ]
}

@nsajko nsajko added backport 1.12 Change should be backported to release-1.12 backport 1.11 Change should be backported to release-1.11 labels Mar 29, 2025
@KristofferC
Copy link
Member

Easier to rename it?

@nsajko nsajko force-pushed the Base__precompilation__precompilepkgs__type_stability_fix_for_showing_progress_str branch from 6979a09 to e45142a Compare March 30, 2025 06:23
@nsajko
Copy link
Contributor Author

nsajko commented Mar 30, 2025

I'm going to squash into one commit, because that seems to be required for autobackport.

@nsajko
_precompilepkgs: interactive progress display: fix unintended capture
0e5f281 
The variable `str` also exists in one of the enclosing closures. Create
a new variable, as was surely intended, instead of capturing and
mutating `str`.

Improves the sysimage's resistance to invalidation.
@nsajko nsajko force-pushed the Base__precompilation__precompilepkgs__type_stability_fix_for_showing_progress_str branch from 3e127da to 0e5f281 Compare March 30, 2025 23:33
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
Merged
36 tasks
@KristofferC KristofferC merged commit fcf492d into JuliaLang:master Mar 31, 2025
5 of 7 checks passed
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@nsajko @KristofferC
_precompilepkgs: interactive progress display: fix unintended captu…
1b0e334 
…re (#57932)

The variable `str` also exists in one of the enclosing closures. Use a
new variable, as was surely intended, instead of capturing and mutating
the `str`.

Improves the sysimage's resistance to invalidation.

(cherry picked from commit fcf492d)
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@nsajko @KristofferC
_precompilepkgs: interactive progress display: fix unintended captu…
b75482b 
…re (#57932)

The variable `str` also exists in one of the enclosing closures. Use a
new variable, as was surely intended, instead of capturing and mutating
the `str`.

Improves the sysimage's resistance to invalidation.

(cherry picked from commit fcf492d)
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
Merged
71 tasks
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@nsajko @KristofferC
_precompilepkgs: interactive progress display: fix unintended captu…
f70dfcf 
…re (#57932)

The variable `str` also exists in one of the enclosing closures. Use a
new variable, as was surely intended, instead of capturing and mutating
the `str`.

Improves the sysimage's resistance to invalidation.

(cherry picked from commit fcf492d)
@nsajko nsajko deleted the Base__precompilation__precompilepkgs__type_stability_fix_for_showing_progress_str branch March 31, 2025 13:31
@KristofferC KristofferC mentioned this pull request Apr 4, 2025
Merged
51 tasks
@KristofferC KristofferC removed backport 1.12 Change should be backported to release-1.12 backport 1.11 Change should be backported to release-1.11 labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler:precompilation Precompilation of modules invalidations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsajko @KristofferC