-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Base
: shell escaping: inference improvement to prevent invalidation
#57915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
IanButterworth
merged 3 commits into
JuliaLang:master
from
nsajko:shell_escape_inference_mapreduce_sum
Mar 30, 2025
Merged
Base
: shell escaping: inference improvement to prevent invalidation
#57915
IanButterworth
merged 3 commits into
JuliaLang:master
from
nsajko:shell_escape_inference_mapreduce_sum
Mar 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents this tree of invalidations resulting from the definition of {
"type": "Tuple{Type{Int64}, Integer}",
"tree": {
"method_instance": {
"method": "var\"#IOBuffer#391\"(read::Union{Nothing, Bool}, write::Union{Nothing, Bool}, append::Union{Nothing, Bool}, truncate::Union{Nothing, Bool}, maxsize::Integer, sizehint::Union{Nothing, Integer}, ::Type{IOBuffer}) @ Base iobuffer.jl:128",
"method_instance": "MethodInstance for Base.var\"#IOBuffer#391\"(::Bool, ::Bool, ::Nothing, ::Bool, ::Int64, ::Integer, ::Type{IOBuffer})"
},
"children": [
{
"method_instance": {
"method": "kwcall(::NamedTuple, ::Type{IOBuffer}) @ Base iobuffer.jl:128",
"method_instance": "MethodInstance for Core.kwcall(::NamedTuple{(:sizehint,), <:Tuple{Integer}}, ::Type{IOBuffer})"
},
"children": [
{
"method_instance": {
"method": "var\"#sprint#446\"(context, sizehint::Integer, ::typeof(sprint), f::Function, args...) @ Base strings/io.jl:106",
"method_instance": "MethodInstance for Base.var\"#sprint#446\"(::Nothing, ::Integer, ::typeof(sprint), ::typeof(Base.escape_microsoft_c_args), ::Vararg{String})"
},
"children": [
{
"method_instance": {
"method": "kwcall(::NamedTuple, ::typeof(sprint), f::Function, args...) @ Base strings/io.jl:106",
"method_instance": "MethodInstance for Core.kwcall(::NamedTuple{(:sizehint,), <:Tuple{Any}}, ::typeof(sprint), ::typeof(Base.escape_microsoft_c_args), ::Vararg{String})"
},
"children": [
{
"method_instance": {
"method": "escape_microsoft_c_args(args::AbstractString...) @ Base shell.jl:495",
"method_instance": "MethodInstance for Base.escape_microsoft_c_args(::Vararg{String})"
},
"children": [
{
"method_instance": {
"method": "escape_microsoft_c_args(cmd::Cmd) @ Base cmd.jl:120",
"method_instance": "MethodInstance for Base.escape_microsoft_c_args(::Cmd)"
},
"children": [
]
}
]
}
]
}
]
},
{
"method_instance": {
"method": "var\"#sprint#446\"(context, sizehint::Integer, ::typeof(sprint), f::Function, args...) @ Base strings/io.jl:106",
"method_instance": "MethodInstance for Base.var\"#sprint#446\"(::Nothing, ::Integer, ::typeof(sprint), ::typeof(Base.shell_escape_csh), ::Vararg{String})"
},
"children": [
{
"method_instance": {
"method": "kwcall(::NamedTuple, ::typeof(sprint), f::Function, args...) @ Base strings/io.jl:106",
"method_instance": "MethodInstance for Core.kwcall(::NamedTuple{(:sizehint,), <:Tuple{Any}}, ::typeof(sprint), ::typeof(Base.shell_escape_csh), ::Vararg{String})"
},
"children": [
{
"method_instance": {
"method": "shell_escape_csh(args::AbstractString...) @ Base shell.jl:345",
"method_instance": "MethodInstance for Base.shell_escape_csh(::Vararg{String})"
},
"children": [
{
"method_instance": {
"method": "shell_escape_csh(cmd::Cmd) @ Base cmd.jl:118",
"method_instance": "MethodInstance for Base.shell_escape_csh(::Cmd)"
},
"children": [
]
}
]
}
]
}
]
}
]
}
]
}
} |
topolarity
reviewed
Mar 28, 2025
nsajko
commented
Mar 28, 2025
Should make the sysimage more resistant to invalidation.
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
topolarity
approved these changes
Mar 28, 2025
b89cf32
to
2873cdd
Compare
merge me bump |
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make the sysimage more resistant to invalidation.