Skip to content

only update fragmentation data for pages that are not lazily freed #57907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

only update fragmentation data for pages that are not lazily freed #57907

merged 1 commit into from
Mar 28, 2025

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Mar 27, 2025 •
edited
Loading

We are including data from lazily freed pages into this metric, which makes it inaccurate.

Thanks @qinsoon for spotting it.

@d-netto d-netto requested a review from qinsoon March 27, 2025 12:31
@d-netto d-netto added GC Garbage collector backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 labels Mar 27, 2025
@d-netto d-netto force-pushed the dcn-fragmentation-stats branch from 896aace to f0bbef9 Compare March 27, 2025 14:48
@d-netto d-netto force-pushed the dcn-fragmentation-stats branch from f0bbef9 to 57eded3 Compare March 27, 2025 17:08
qinsoon
qinsoon approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-netto d-netto merged commit d6fdbf5 into master Mar 28, 2025
7 checks passed
@d-netto d-netto deleted the dcn-fragmentation-stats branch March 28, 2025 04:56
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@d-netto @KristofferC
only update fragmentation data for pages that are not lazily freed (#…
46ddb2f 
…57907)

We are including data from lazily freed pages into this metric, which
makes it inaccurate.

Thanks @qinsoon for spotting it.

(cherry picked from commit d6fdbf5)
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
Merged
36 tasks
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@d-netto @KristofferC
only update fragmentation data for pages that are not lazily freed (#…
f661509 
…57907)

We are including data from lazily freed pages into this metric, which
makes it inaccurate.

Thanks @qinsoon for spotting it.

(cherry picked from commit d6fdbf5)
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
Merged
71 tasks
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@d-netto @KristofferC
only update fragmentation data for pages that are not lazily freed (#…
a2460d3 
…57907)

We are including data from lazily freed pages into this metric, which
makes it inaccurate.

Thanks @qinsoon for spotting it.

(cherry picked from commit d6fdbf5)
@KristofferC KristofferC mentioned this pull request Apr 4, 2025
Merged
51 tasks
@KristofferC KristofferC removed backport 1.12 Change should be backported to release-1.12 backport 1.11 Change should be backported to release-1.11 labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
GC Garbage collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-netto @qinsoon @KristofferC