only show backdated binding warning when deprecation warnings are enabled #57886
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The backdating thing was supposed to be quite temporary - possibly even removed by 1.12 final, which is why we didn't put it under the depwarn flag originally. Are there any common patterns to these outdated accesses? It wasn't really supposed to be all that common to hit this. |
This was referenced Mar 31, 2025
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is way too spammy right now. You precompile a set of packages and then have pages and pages of this warning. Don't think that is ok to introduce by default in a minor release. With the same argument that deprecation warnings are disabled by default, I think this should be as well.