AnnotatedString: add concrete type asserts to isvalid, ncodeunits
#57607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type assertions are valid according to the doc strings of these two functions in the case of `AbstractString`. Should prevent some invalidation of user code. Fixes JuliaLang#57606
|
I was not able to make a minimal reproducer quickly, but this change reduces the invalidation on loading my package TypeDomainNaturalNumbers (registered, v6.1.0). |
tecosaur
approved these changes
Mar 3, 2025
fingolfin
approved these changes
Mar 3, 2025
nsajko
added
backport 1.11
KristofferC
removed
the
backport 1.12
KristofferC
removed
the
backport 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type assertions are valid according to the doc strings of these two functions in the case of
AbstractString.Should prevent some invalidation on loading user code.
Fixes #57606