cfunction: reimplement, as originally planned, for reliable performance #57226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
compiler:codegen
vtjnash
force-pushed
the
jn/fast-cfunction-update
branch
from
524b478 to
07dce1e
Compare
|
I will read this in more detail soon but looks nice 👍 |
vtjnash
force-pushed
the
jn/fast-cfunction-update
branch
2 times, most recently
from
1be6ee4 to
65f1345
Compare
32 tasks
gbaraldi
reviewed
Feb 5, 2025
| jl_method_instance_t *mi = jl_get_specialization1((jl_tupletype_t*)sigt, latestworld, 0); | ||
| if (mi) { | ||
| auto it = compiled_mi.find(mi); | ||
| if (it != compiled_mi.end()) { |
There was a problem hiding this comment.
Maybe also do a cache lookup for 0b100 i.e looking for code in a packageimage
This implements several sources of bugfixes and improvements: - direct edges are correctly represented - performance does not degrade when edges trigger - the JIT does not call `jl_infer_type` until actually required - constant return can handle invalidation and emitting efficient code This generates the code for the exact signature specified by the user, instead of using `jl_infer_type` to compute a different signature which previously might cause unnecessary boxing and previously introduced unstable performance characteristics. This lets us defer generating the actual thunk required at runtime with the JIT when the required information is already available, and also to validate that information is still correct, and regenerate it when not correct anymore.
vtjnash
force-pushed
the
jn/fast-cfunction-update
branch
from
65f1345 to
198310f
Compare
KristofferC
added a commit
that referenced
this pull request
Feb 13, 2025
Backported PRs: - [x] #57142 <!-- Add reference to time_ns in time --> - [x] #57241 <!-- Handle `waitpid` race condition when `SIGCHLD` is set to `SIG_IGN` --> - [x] #57249 <!-- restore non-freebsd-unix fix for profiling --> - [x] #57211 <!-- Ensure read/readavailable for BufferStream are threadsafe --> - [x] #57262 <!-- edit NEWS for v1.12 --> - [x] #57226 <!-- cfunction: reimplement, as originally planned, for reliable performance --> - [x] #57253 <!-- bpart: Fully switch to partitioned semantics --> - [x] #57273 <!-- fix "Right arrow autocompletes at line end" implementation --> - [x] #57280 <!-- dep: Update JuliaSyntax --> - [x] #57229 <!-- staticdata: Close data race after backedge insertion --> - [x] #57298 <!-- Updating binding version to fix MMTk CI --> - [x] #57248 <!-- improve concurrency safety for `Compiler.finish!` --> - [x] #57312 <!-- Profile.print: de-focus sleeping frames as gray --> - [x] #57289 <!-- Make `OncePerX` subtype `Function` --> - [x] #57310 <!-- Make ptls allocations at least 128 byte aligned --> - [x] #57311 <!-- Add a warning for auto-import of types --> - [x] #57338 <!-- fix typo in Float32 random number generation --> - [x] #57293 <!-- Fix getfield_tfunc when order or boundscheck is Vararg --> - [x] #57349 <!-- docs: fix-up world-age handling for META access --> - [x] #57344 <!-- Add missing type asserts when taking the queue out of the task struct --> - [x] #57348 <!-- 🤖 [master] Bump the SparseArrays stdlib from 212981b to 72c7cac --> - [x] #55040 <!-- Allow macrocall as function sig --> - [x] #57299 <!-- Add missing latestworld after parameterized type alias -->
KristofferC
removed
the
backport 1.12
|
@vtjnash This broke GPUCompiler.jl; compiling a single one-function kernel, |
|
-5 is the info code for an unhandled constant function and 0 is the expected result when nothing needed to be compiled since it can not get called |
|
The example I'm looking at indeed involves a constant function ( |
|
Sorry for the noob-ish question. What versions of julia will this hit? Will it be in 1.10 or 1.11? |
|
v1.12 |
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements several sources of bugfixes and improvements:
jl_infer_typeuntil actually requiredThis generates the code for the exact signature specified by the user, instead of using
jl_infer_typeto compute a different signature which previously might cause unnecessary boxing and previously introduced unstable performance characteristics. This lets us defer generating the actual thunk required at runtime with the JIT when the required information is already available, and also to validate that information is still correct, and regenerate it when not correct anymore.