Put jl_gc_new_weakref in a header file again
#56319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
approved these changes
Oct 24, 2024
|
Thank you! Yes, libjulia needs the updated header. Since I only rebuilt it a few days ago, it should be trivial enough to do it again once this PR is merged |
fingolfin
approved these changes
Oct 24, 2024
d-netto
approved these changes
Oct 24, 2024
d-netto
reviewed
Oct 24, 2024
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
|
Unfortunately this is not quite enough, as just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcext implementation in gap/GAP.jl uses
jl_gc_new_weakref. Since #55608 got merged, this symbol is no longer mentioned in any header file, and thus the compilation of gap fails. This PR puts it back into a header file, but now ingc-common.h(instead ofgc-interface.h), since #55608 moved the implementation togc-common.c.We are aware of the alternative function
jl_gc_new_weakref_th(that still is in a header after #55608). However, it was not present in any header file before #55256, even though it was already marked asJL_DLLEXPORTwell before that.In short, without this PR we are not able to adapt the code to a way that works both with julia 1.11 and nightly.
@fingolfin I get locally still the same error as we can observe in CI. I suppose that this needs a rebuild of
libjuliawith this PR here included to work, right?ping @d-netto @gbaraldi