inference: Switch to typename-based override for constprop heuristics #55288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #55271, I'd like to get rid of `istopfunction` for various reasons. Rather than hardcoding constprop overrides based on binding name, this annotates the relevant TypeNames (like the existing `max_methods` override), removing the binding lookups from inference.
aviatesk
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
This might be the best way to implement the special cases.
I came up with this alternative, but I don't think this is necessarily more elegant than this approach:
Core.Compiler
const functions_with_sametype_heuristic = Any[]base/essentials.jl
for f = Any[+, -, *, ==, !=, <=, >=, <, >, <<, >>]
push!(Core.Compiler.functions_with_sametype_heuristic, f)
end
|
The problem with using an array in the compiler is that you can't use it in pkgimages. We don't have a use case for that right now, but I don't see a good reason for the restriction. |
Yeah, I agree. |
vtjnash
approved these changes
Jul 29, 2024
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
…JuliaLang#55288) As mentioned in JuliaLang#55271, I'd like to get rid of `istopfunction` for various reasons. Rather than hardcoding constprop overrides based on binding name, this annotates the relevant TypeNames (like the existing `max_methods` override), removing the binding lookups from inference.
Keno
added a commit
that referenced
this pull request
Oct 23, 2024
This commit teaches to compiler to update its world bounds whenever it looks at a binding partition, making the compiler sound in the presence of a partitioned binding. The key adjustment is that the compiler is no longer allowed to directly query the binding table without recording the world bounds, so all the various abstract evaluations that look at bindings need to be adjusted and are no longer pure tfuncs. We used to look at bindings a lot more, but thanks to earlier prep work to remove unnecessary binding-dependent code (#55288, #55289 and #55271), these changes become relatively straightforward. Note that as before, we do not create any binding partitions by default, so this commit is mostly preperatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #55271, I'd like to get rid of
istopfunctionfor various reasons. Rather than hardcoding constprop overrides based on binding name, this annotates the relevant TypeNames (like the existingmax_methodsoverride), removing the binding lookups from inference.