Small change to docs for module import syntax #54575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
dpa/small-change-module-qualified-names
branch
from
f6e4e5c to
d825d98
Compare
KristofferC
added
docs
DilumAluthge
force-pushed
the
dpa/small-change-module-qualified-names
branch
from
d825d98 to
bce50b3
Compare
|
Ugh. I've borked the rebase. I'll fix it. |
DilumAluthge
removed
the
merge me
Note: the base branch (target branch) of this PR is `kc/warn_using` (#42080), NOT `master`. --- This is additive to #42080 which adds advice to the docstring of `using` . The wording here is a tweaked version of @IanButterworth's suggestion here: #42080 (comment) --------- Co-authored-by: Max Horn <max@quendi.de> Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
DilumAluthge
force-pushed
the
dpa/small-change-module-qualified-names
branch
from
bce50b3 to
b4dd31f
Compare
|
Okay, I think I've fixed the rebase now. |
DilumAluthge
force-pushed
the
dpa/small-change-module-qualified-names
branch
from
b4dd31f to
15a8791
Compare
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
DilumAluthge
force-pushed
the
dpa/small-change-module-qualified-names
branch
from
15a8791 to
8bd8c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the base branch (target branch) of this PR is
kc/warn_using(#42080), NOTmaster.This small change was originally part of #53428. However, it caused confusion during PR review. So I removed this change from #53428 (in 862a546), and I've put that change into this PR.
Just to clarify, the language about "keeping the namespace clean" already existed on master prior to #53428 (and prior to this PR). All this PR does is:
import ModuleName" to "import ModuleNameorusing ModuleName: ModuleName".