print types more verbosely in page profiler #53256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-netto
force-pushed
the
dcn-page-profiler-more-verbose-types
branch
3 times, most recently
from
3994fc1
to
92f8ffe
Compare
d-netto
force-pushed
the
dcn-page-profiler-more-verbose-types
branch
4 times, most recently
from
3af9d84
to
3f0f911
Compare
vtjnash
reviewed
Feb 10, 2024
vtjnash
reviewed
Feb 10, 2024
vtjnash
reviewed
Feb 10, 2024
d-netto
force-pushed
the
dcn-page-profiler-more-verbose-types
branch
10 times, most recently
from
402f933
to
4b01e58
Compare
Merged
d-netto
force-pushed
the
dcn-page-profiler-more-verbose-types
branch
6 times, most recently
from
e03a5c9
to
ec182a4
Compare
d-netto
force-pushed
the
dcn-page-profiler-more-verbose-types
branch
from
ec182a4
to
670393c
Compare
d-netto
added a commit
to RelationalAI/julia
that referenced
this pull request
Jun 28, 2024
Instead of just printing `Tuple`, print the full type signature such as
`Tuple{UnionAll, GenericMemory{:not_atomic, Tuple{Int64, Int64,
Array{Pair{Any, Any}, 1}}, Core.AddrSpace{Core}(0x00)}, Int64}`
d-netto
added a commit
to RelationalAI/julia
that referenced
this pull request
Jul 3, 2024
Instead of just printing `Tuple`, print the full type signature such as
`Tuple{UnionAll, GenericMemory{:not_atomic, Tuple{Int64, Int64,
Array{Pair{Any, Any}, 1}}, Core.AddrSpace{Core}(0x00)}, Int64}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just printing
Tuple, print the full type signature such asTuple{UnionAll, GenericMemory{:not_atomic, Tuple{Int64, Int64, Array{Pair{Any, Any}, 1}}, Core.AddrSpace{Core}(0x00)}, Int64}