refactors interpreter_exec.jl further
#53246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
kf/interpexectest
branch
from
dfdb1d7 to
50cbe14
Compare
aviatesk
force-pushed
the
avi/more-refactor-interpexectest
branch
from
c4dfacf to
7c75ed4
Compare
vtjnash
approved these changes
Feb 8, 2024
aviatesk
force-pushed
the
kf/interpexectest
branch
from
6409469 to
ab74bc2
Compare
This commit refines `interpreter_exec.jl` further, on top of #53218. In detail, by using `Base.Experimental.@compiler_options compile=min`, it's now possible to mimic the effect of `julia --compile=[min|yes]`. This commit is leveraging it and includes `interpreter_exec.jl` from `test/compiler/ssair.jl`, allowing us to get better stack traces and test summaries. In addition, I've introduced several tests concerning the `src.inferred` values and have relocated the tests from #47066 within `interpreter_exec.jl` to `test/compiler/irpasses.jl`, since it is related to Julia-level compilation and not to interpreter execution.
aviatesk
force-pushed
the
avi/more-refactor-interpexectest
branch
from
7c75ed4 to
28d22ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refines
interpreter_exec.jlfurther, on top of #53218. In detail, by usingBase.Experimental.@compiler_options compile=min, it's now possible to mimic the effect ofjulia --compile=[min|yes]. This commit is leveraging it and includesinterpreter_exec.jlfromtest/compiler/ssair.jl, allowing us to get better stack traces and test summaries.In addition, I've introduced several tests concerning the
src.inferredvalues and have relocated the tests from #47066 withininterpreter_exec.jltotest/compiler/irpasses.jl, since it is related to Julia-level compilation and not to interpreter execution.