absint: merge const_prop_enabled into bail_out_const_call
#52921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these interfaces have nearly identical roles. Considering the simplicity in the codebase and the possible overloads by external abstract interpreters, it seems more sensible to unify them into one interface.
aviatesk
force-pushed
the
avi/unify-const-bail-out
branch
from
295390d to
66c9811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these interfaces have nearly identical roles. Considering the simplicity in the codebase and the possible overloads by external abstract interpreters, it seems more sensible to unify them into one interface.
Also tweaks remarks a bit.