Lowering: Insert QuoteNode for captured boxed value #52596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
needs tests
aviatesk
approved these changes
Dec 21, 2023
aviatesk
force-pushed
the
vc/qn_setfield!
branch
2 times, most recently
from
a65ee47
to
e2cb27b
Compare
aviatesk
force-pushed
the
vc/qn_setfield!
branch
from
e2cb27b
to
4569e51
Compare
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
aviatesk
force-pushed
the
vc/qn_setfield!
branch
from
4569e51
to
4f95066
Compare
KristofferC
pushed a commit
that referenced
this pull request
Dec 23, 2023
`Core.Box` is not self-quoting so it should be captured in a QuoteNode. This has been benign until the improved effect system, we handle `QuoteNode` of a mutable value as a global access, whereas a direct reference to a value is treated as inaccessible memory. Fixes #52531 --------- Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com> Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com> (cherry picked from commit 1290b51)
aviatesk
removed
the
backport 1.10
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jun 7, 2024
…ng#52878) Issues like JuliaLang#52531 were more broadly fixed by JuliaLang#52856. This commit partially reverts JuliaLang#52596, while leaving the added tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core.Boxis not self-quoting so it should be captured in a QuoteNode.This has been benign until the improved effect system, we handle
QuoteNodeof a mutable value as a global access, whereas a direct reference to a value
is treated as inaccessible memory.
Fixes #52531