Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: fix istuple check in apply_type_tfunc #52585

Merged
merged 1 commit into from
Dec 20, 2023
Merged

inference: fix istuple check in apply_type_tfunc #52585

merged 1 commit into from
Dec 20, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Dec 19, 2023

close #51927

@N5N3 N5N3 added the compiler:inference Type inference label Dec 19, 2023
@vtjnash vtjnash added the backport 1.10 Change should be backported to the 1.10 release label Dec 19, 2023
aviatesk
aviatesk approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we probably want to double check with @Keno before merge.

Keno
Keno approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct. This is one of the special cases in the apply_type implementation which works on object identity.

@N5N3 N5N3 merged commit 58fac69 into JuliaLang:master Dec 20, 2023
7 of 9 checks passed
@N5N3 N5N3 deleted the istuplefix branch December 20, 2023 14:17
KristofferC pushed a commit that referenced this pull request Dec 23, 2023
@N5N3 @KristofferC
inference: fix istuple check in apply_type_tfunc (#52585)
24b525d 
close #51927

(cherry picked from commit 58fac69)
@aviatesk aviatesk removed the backport 1.10 Change should be backported to the 1.10 release label Dec 24, 2023
@mofeing mofeing mentioned this pull request Oct 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

map from Int to Type fails in promote_typejoin_union
4 participants
@N5N3 @Keno @aviatesk @vtjnash