Don't reuse passmanagers across compilations #52054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Nov 6, 2023
gbaraldi
force-pushed
the
gb/dont-reuse-pm
branch
from
81a1b89
to
4d02f43
Compare
gbaraldi
force-pushed
the
gb/dont-reuse-pm
branch
from
4d02f43
to
217f480
Compare
vtjnash
approved these changes
Nov 19, 2023
|
The annoying part is that we pay the cost of rebuilding those data structures every run. But it doesn't seem to be affecting things too much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://reviews.llvm.org/D137149, it's not legal to reuse the pipeline across compilations.
While we want to get back into doing that, from some very quick measurements I wasn't able to measure any difference (It wasn't extensive)
In order to stop doing this, I will propose some discussions upstream in order to make passes aware that their state should go in the AnalysisManager.
This also reinstates the StandardInstrumentation with LLVM16 built