Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse passmanagers across compilations #52054

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Nov 6, 2023

According to https://reviews.llvm.org/D137149, it's not legal to reuse the pipeline across compilations.
While we want to get back into doing that, from some very quick measurements I wasn't able to measure any difference (It wasn't extensive)
In order to stop doing this, I will propose some discussions upstream in order to make passes aware that their state should go in the AnalysisManager.

This also reinstates the StandardInstrumentation with LLVM16 built

src/pipeline.cpp Outdated Show resolved Hide resolved
src/pipeline.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need to reuse things, that it is certainly easier not to

@gbaraldi
Copy link
Member Author

The annoying part is that we pay the cost of rebuilding those data structures every run. But it doesn't seem to be affecting things too much

@gbaraldi gbaraldi merged commit 79a845c into master Nov 23, 2023
7 checks passed
@gbaraldi gbaraldi deleted the gb/dont-reuse-pm branch November 23, 2023 19:04
mkitti pushed a commit to mkitti/julia that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants