Allow using ReturnNode() in @generated code
#51715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pangoraw
force-pushed
the
untyped_unreachable
branch
from
e7e24ee
to
768f1d3
Compare
simeonschaub
added
backport 1.9
simeonschaub
added a commit
to FluxML/IRTools.jl
that referenced
this pull request
Oct 16, 2023
…115) * Use Core.throw("unreachable") for unreachables `ReturnNode()` only appears later in the Julia compiler optimization pipeline. * Use returnode() when possible * Update src/ir/wrap.jl Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> --------- Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Oct 23, 2023
IRTools.jl currently tries to use `ReturnNode()` to model unreachable block terminators but it fails in `find_ssavalue_uses`. This PR adds a check to enable using `ReturnNode()` in untyped code. One other alternative for frontends is to use an instruction known to terminate (`Core.throw`) instead. See FluxML/IRTools.jl#115 for more context. (cherry picked from commit ff03e51)
KristofferC
removed
the
backport 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRTools.jl currently tries to use
ReturnNode()to model unreachable block terminators but it fails infind_ssavalue_uses. This PR adds a check to enable usingReturnNode()in untyped code.One other alternative for frontends is to use an instruction known to terminate (
Core.throw) instead. See FluxML/IRTools.jl#115 for more context.