Skip to content

Add excise stdlib script #51550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add excise stdlib script #51550

merged 2 commits into from
Oct 6, 2023

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Oct 2, 2023

Two tests performed:

https://github.com/JuliaLang/LazyArtifacts.jl

and with a slightly older version:

https://github.com/JuliaLang/Test.jl

@DilumAluthge
Copy link
Member

Could you stick something like gh --version or which gh at the top of the script? That way, if the user forgot to install the gh CLI, they get notified immediately, instead of having to wait until all the other stuff runs.

#!/bin/bash

# Uses https://github.com/newren/git-filter-repo
# Recommended use of `Github cli`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a comment pointing to the homepage (https://cli.github.com/), so that users can get to the installation instructions easily?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh is just a recommendation. It's not actively used in the script. I decided that the push to github is best done manually after the user inspects the result.

@brenhinkeller brenhinkeller added the stdlib Julia's standard library label Oct 3, 2023
Co-authored-by: Alex Arslan <ararslan@comcast.net>
@vchuravy vchuravy merged commit 6fc6a97 into master Oct 6, 2023
@vchuravy vchuravy deleted the vc/contrib_excise_stdlib branch October 6, 2023 19:40
@IanButterworth IanButterworth mentioned this pull request Oct 7, 2023
DilumAluthge added a commit that referenced this pull request Oct 7, 2023
From #51550

---------

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants