Skip to content

Don't mark nonlocal symbols as hidden #51530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2023
Merged

Don't mark nonlocal symbols as hidden #51530

merged 2 commits into from
Oct 2, 2023

Conversation

pchintalapudi
Copy link
Member

@pchintalapudi pchintalapudi added the compiler:precompilation Precompilation of modules label Sep 30, 2023
vchuravy
vchuravy reviewed Oct 1, 2023
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the added test.

@vchuravy vchuravy added the backport 1.10 Change should be backported to the 1.10 release label Oct 2, 2023
@vchuravy vchuravy merged commit ac8246f into master Oct 2, 2023
@vchuravy vchuravy deleted the pc/ccallable-extern branch October 2, 2023 12:42
KristofferC pushed a commit that referenced this pull request Oct 3, 2023
@pchintalapudi @vchuravy
Don't mark nonlocal symbols as hidden (#51530)
e1f1cc8 
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
(cherry picked from commit ac8246f)
@KristofferC KristofferC mentioned this pull request Oct 3, 2023
Merged
31 tasks
@IanButterworth
Copy link
Member

Seems like the error is still happening on master? f2d1276

  | Error in testset precompile:
  | Error During Test at C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:20
  | Got exception outside of a @test
  | f35014 not found in sysimg
  | Stacktrace:
  | [1] _include_from_serialized(pkg::Base.PkgId, path::String, ocachepath::String, depmods::Vector{Any})
  | @ Base .\loading.jl:1059
  | [2] _tryrequire_from_serialized(pkg::Base.PkgId, path::String, ocachepath::String)
  | @ Base .\loading.jl:1532
  | [3] _require(pkg::Base.PkgId, env::String)
  | @ Base .\loading.jl:1988
  | [4] __require_prelocked(uuidkey::Base.PkgId, env::String)
  | @ Base .\loading.jl:1813
  | [5] #invoke_in_world#3
  | @ Base .\essentials.jl:933 [inlined]
  | [6] invoke_in_world
  | @ Base .\essentials.jl:930 [inlined]
  | [7] _require_prelocked(uuidkey::Base.PkgId, env::String)
  | @ Base .\loading.jl:1804
  | [8] macro expansion
  | @ Base .\loading.jl:1791 [inlined]
  | [9] macro expansion
  | @ Base .\lock.jl:267 [inlined]
  | [10] __require(into::Module, mod::Symbol)
  | @ Base .\loading.jl:1754
  | [11] #invoke_in_world#3
  | @ .\essentials.jl:933 [inlined]
  | [12] invoke_in_world
  | @ .\essentials.jl:930 [inlined]
  | [13] require
  | @ .\loading.jl:1747 [inlined]
  | [14] (::Main.Test17Main_precompile.var"#2#22"{String})(dir::String)
  | @ Main.Test17Main_precompile C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:286
  | [15] precompile_test_harness(f::Any, separate::Bool)
  | @ Main.Test17Main_precompile C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:30
  | [16] (::Main.Test17Main_precompile.var"#1#21")(dir2::String)
  | @ Main.Test17Main_precompile C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:101
  | [17] precompile_test_harness(f::Any, separate::Bool)
  | @ Main.Test17Main_precompile C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:30
  | [18] macro expansion
  | @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:21 [inlined]
  | [19] macro expansion
  | @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\stdlib\v1.11\Test\src\Test.jl:1598 [inlined]
  | [20] precompile_test_harness(f::Any, testset::String)
  | @ Main.Test17Main_precompile C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:21
  | [21] top-level scope
  | @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\precompile.jl:100
  | [22] include
  | @ .\Base.jl:497 [inlined]
  | [23] macro expansion
  | @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\testdefs.jl:30 [inlined]
  | [24] macro expansion
  | @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\stdlib\v1.11\Test\src\Test.jl:1598 [inlined]
  | [25] macro expansion
  | @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\testdefs.jl:23 [inlined]
  | [26] macro expansion
  | @ .\timing.jl:506 [inlined]
  | [27] runtests(name::String, path::String, isolate::Bool; seed::UInt128)
  | @ Main C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\testdefs.jl:21
  | [28] invokelatest(::Any, ::Any, ::Vararg{Any}; kwargs::@Kwargs{seed::UInt128})
  | @ Base .\essentials.jl:901
  | [29] (::var"#31#39")()
  | @ Main C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\runtests.jl:318
  | [30] cd(f::var"#31#39", dir::String)
  | @ Base.Filesystem .\file.jl:101
  | [31] top-level scope
  | @ C:\buildkite-agent\builds\win2k22-amdci6-1\julialang\julia-master\julia-f2d1276be8\share\julia\test\runtests.jl:95
  | [32] include(mod::Module, _path::String)
  | @ Base .\Base.jl:497
  | [33] exec_options(opts::Base.JLOptions)
  | @ Base .\client.jl:317
  | [34] _start()
  | @ Base .\client.jl:569

vchuravy added a commit that referenced this pull request Oct 3, 2023
@vchuravy
Revert "Don't mark nonlocal symbols as hidden (#51530)"
e6e2f1c 
This reverts commit ac8246f.
@vchuravy vchuravy mentioned this pull request Oct 3, 2023
Merged
@vchuravy vchuravy removed the backport 1.10 Change should be backported to the 1.10 release label Oct 3, 2023
IanButterworth added a commit that referenced this pull request Oct 4, 2023
@IanButterworth
Revert "Don't mark nonlocal symbols as hidden (#51530)"
ddec9e4 
This reverts commit e1f1cc8.
KristofferC added a commit that referenced this pull request Nov 2, 2023
@KristofferC
Backports release 1.10 (#51563)
1391444 
Backported PRs:
- [x] #50932 <!-- types: fix hash values of Vararg -->
- [x] #50975 <!-- Use rr-safe `nopl; rdtsc` sequence -->
- [x] #50989 <!-- fix incorrect results in `expm1(::Union{Float16,
Float32})` -->
- [x] #51284 <!-- Avoid infinite loop when doing SIGTRAP in arm64-apple
-->
- [x] #51332 <!-- Add s4 field to Xoshiro -->
- [x] #51397 <!-- call Pkg precompile hook in latest world -->
- [x] #51405 <!-- Remove fallback that assigns a module to inlined
frames. -->
- [x] #51491 <!-- Throw clearer ArgumentError for strip with two string
args -->
- [x] #51531 <!-- fix `_tryonce_download_from_cache` (busybox.exe
download error) -->
- [x] #51541 <!-- Fix string index error in tab completion code -->
- [x] #51530 <!-- Don't mark nonlocal symbols as hidden -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51512 <!-- avoid limiting Type{Any} to Type -->
- [x] #51595 <!-- reset `maxprobe` on `empty!` -->
- [x] #51582 <!-- Aggressive constprop in LinearAlgebra.wrap -->
- [x] #51592 <!-- correctly track element pointer in heap snapshot -->
- [x] #51326 <!-- complete false & true more generally as vals -->
- [x] #51376 <!-- make `hash(::Xoshiro)` compatible with `==` -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51845 
- [x] #51840 
- [x] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [x] #51863 <!-- LLVM 15.0.7-9 -->

Contains multiple commits, manual intervention needed:

- [ ] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are
now first class -->
- [ ] #51092 <!-- inference: fix bad effects for recursion -->

Non-merged PRs with backport label:
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
- [ ] #51414 <!-- improvements on GC scheduler shutdown -->
- [ ] #51366 <!-- Handle infix operators in REPL completion -->
- [ ] #50919 <!-- Code loading: do the "skipping mtime check for stdlib"
check regardless of the value of `ispath(f)` -->
- [ ] #50824 <!-- Add some aliasing warnings to docstrings for mutating
functions in Base -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
nalimilan pushed a commit that referenced this pull request Nov 5, 2023
@pchintalapudi @vchuravy @nalimilan
Don't mark nonlocal symbols as hidden (#51530)
624404d 
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
(cherry picked from commit ac8246f)
@vchuravy vchuravy mentioned this pull request May 23, 2024
Merged
@mofeing mofeing mentioned this pull request Oct 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
compiler:precompilation Precompilation of modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pchintalapudi @IanButterworth @vchuravy @vtjnash