Reactivate automatic nospecialize for unused arguments #50722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clearly the bug is still present: |
|
Darn! I'm afraid fixing that is beyond my competence ... |
vtjnash
added a commit
that referenced
this pull request
Aug 18, 2023
This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries. Fixes: #50722 (comment)
vchuravy
force-pushed
the
nospecialize-unused-args
branch
from
908016c to
19090e7
Compare
KristofferC
pushed a commit
that referenced
this pull request
Mar 26, 2025
This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries. Fixes: #50722 (comment) (cherry picked from commit 762801c)
KristofferC
force-pushed
the
nospecialize-unused-args
branch
from
19090e7 to
1fae15a
Compare
|
I was pretty sure we'd already concluded this was actually pretty bad for performance, so we'd closed it already |
|
Then the TODO should be removed, no? |
If this is bad for performance, should things like |
nickrobinson251
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Mar 27, 2025
This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries. Fixes: JuliaLang#50722 (comment) (cherry picked from commit 762801c)
nickrobinson251
added a commit
to RelationalAI/julia
that referenced
this pull request
Mar 27, 2025
This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries. Fixes: JuliaLang#50722 (comment) (cherry picked from commit 762801c) Co-authored-by: Jameson Nash <vtjnash@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries. Fixes: #50722 (comment) (cherry picked from commit 762801c)
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries. Fixes: #50722 (comment) (cherry picked from commit 762801c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactivate automatic nospecialize for unused arguments, to avoid unnecessary code generation in use cases like
(let's see if the bug mentioned in the code is gone by now).
Maybe even use the new
@nospecializeinfer? (I don't know how to do this in C though :-) ).CC @JeffBezanson , @LilithHafner (our discussion at JuliaCon).