Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Base.lib{blas,lapack}_name #50699

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

staticfloat
Copy link
Member

These have been deprecated for a long time, users should instead use
LinearAlgebra.BLAS.libblas or LinearAlgebra.BLAS.liblapack.

This will be necessary once we have lazy JLLs, as it's not desirable to
recreate the dependency graph in Base, we already have it in standard
libraries, and only load libblastrampoline when LinearAlgebra starts
doing ccalls.

@staticfloat staticfloat requested a review from vtjnash July 27, 2023 20:07
@staticfloat staticfloat marked this pull request as ready for review July 27, 2023 20:07
@staticfloat
Copy link
Member Author

I think we definitely need to run PkgEval on this, to find more examples such as: JuliaLinearAlgebra/BandedMatrices.jl#386

@vtjnash vtjnash added the needs pkgeval Tests for all registered packages should be run with this change label Jul 27, 2023
@vtjnash vtjnash removed their request for review July 27, 2023 21:31
@jishnub
Copy link
Contributor

jishnub commented Jul 28, 2023

Related: #44360 and #47477

@ViralBShah
Copy link
Member

I believe the decision from the last time was that removing these caused a lot of breakage. It does seem that most packages have been updated to avoid using the old names.

Are we good to merge this now?

These have been deprecated for a long time, users should instead use
`LinearAlgebra.BLAS.libblas` or `LinearAlgebra.BLAS.liblapack`.

This will be necessary once we have lazy JLLs, as it's not desirable to
recreate the dependency graph in `Base`, we already have it in standard
libraries, and only load libblastrampoline when `LinearAlgebra` starts
doing ccalls.
@staticfloat
Copy link
Member Author

staticfloat commented Jun 8, 2024

Let's run PkgEval on it, just to see if the breakage is contained enough now.

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@ViralBShah
Copy link
Member

ViralBShah commented Jun 10, 2024

Looks like 70 odd packages still have libblas_name or liblapack_name. Maybe we need a call to action on Discourse with a list of these packages.

zsoerenm pushed a commit to JuliaGNSS/KalmanFilters.jl that referenced this pull request Jun 11, 2024
pxl-th pushed a commit to FluxML/NNlib.jl that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs pkgeval Tests for all registered packages should be run with this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants