remove :boundscheck
argument from Core._svec_ref
#50561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core._svec_ref
has acceptedboundscheck
-value as the first argument since it was added in #45062. Nonetheless,Core._svec_ref
simply callsjl_svec_ref
in either the interpreter or the codegen, and thus theboundscheck
value isn't utilized in any optimizations. Rather, even worse, thisboundscheck
-argument negatively influences the effect analysis (xref #50167 for details) and has caused type inference regressions as reported in #50544.For these reasons, this commit simply eliminates the
boundscheck
argument fromCore._svec_ref
. Consequently,getindex(::SimpleVector, ::Int)
is now being concrete-eval eligible.closes #50544