Make apply_type_nothrow robust against TypeVars in upper bounds
#49863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For types like `Foo{S, T<:S}`, `apply_type_nothrow` could in some
situations check whether the argument is a subtype of the upper bound of
`T`, i.e. `S`, but subtyping agaist a plain `TypeVar` would fail.
Instead return `false` in this case.
Fixes #49785.
aviatesk
approved these changes
May 18, 2023
everywhere. Is that happening elsewhere, too? Or could this PR have caused it? |
|
Just needs a rebase. (which I did) |
vtjnash
reviewed
May 20, 2023
| @@ -1665,7 +1665,7 @@ function apply_type_nothrow(𝕃::AbstractLattice, argtypes::Vector{Any}, @nospe | |||
| end | |||
| else | |||
| istype || return false | |||
| if !(T <: u.var.ub) | |||
| if isa(u.var.ub, TypeVar) || !(T <: u.var.ub) | |||
There was a problem hiding this comment.
This could also do has_free_typevars(u.var.ub) to cover some other (even more rare) cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For types like
Foo{S, T<:S},apply_type_nothrowcould in some situations check whether the argument is a subtype of the upper bound ofT, i.e.S, but subtyping agaist a plainTypeVarwould fail. Instead returnfalsein this case.Fixes #49785.