Skip to content

Rename ipython_mode to numbered_prompt #49314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2023
Merged

Rename ipython_mode to numbered_prompt #49314

merged 4 commits into from
Apr 14, 2023

Conversation

hyrodium
Copy link
Contributor

I love the feature of ipython_mode, but I disagree with its name because:

  • The feature is less related to IPython.
  • I feel like there's not enough respect for our ancestors who developed Mathematica.

Fortunately, it's before the release of Julia v1.9, and I think it's a good opportunity to reconsider the name.
#46474 (comment)

@hyrodium
Copy link
Contributor Author

Reactions to my proposal for the renaming seem positive on Slack.

image

https://julialang.slack.com/archives/C67TK21LJ/p1681139172800279

@KristofferC
Copy link
Member

KristofferC commented Apr 10, 2023 •
edited
Loading

If IPython mode is too strong, then softening it to e.h. ipython_prompt feels ok (since this is clearly not emulating the full IPyhton REPL experience). The suggested numbered_mode feels very bland.

@pabloferz
Copy link
Contributor

Why not notebook_mode?

@KristofferC
Copy link
Member

KristofferC commented Apr 10, 2023 •
edited
Loading

Because that makes it sounds like it provides some notebook functionality. As I said before, I do think the mode term is a bit too broad. notebook_prompt miiight be ok.

@IanButterworth
Copy link
Member

IanButterworth commented Apr 10, 2023 •
edited
Loading

What about numbered_prompt?

@hyrodium
Copy link
Contributor Author

I think numbered_prompt is the current best choice, so I have updated this PR.

@hyrodium hyrodium changed the title Rename ipython_mode to numbered_mode Rename ipython_mode to numbered_prompt Apr 11, 2023
@hyrodium hyrodium mentioned this pull request Apr 11, 2023
Merged
@JeffBezanson JeffBezanson added the backport 1.9 Change should be backported to release-1.9 label Apr 12, 2023
@JeffBezanson
Copy link
Member

💯 This is much better; the current name makes it sound like there is some kind of full IPython emulation, or that it will actually run IPython, or something. And IPython is not even called that anymore 😉

@JeffBezanson JeffBezanson added the REPL Julia's REPL (Read Eval Print Loop) label Apr 12, 2023
JeffBezanson
JeffBezanson reviewed Apr 12, 2023
View reviewed changes
hyrodium and others added 2 commits April 13, 2023 08:54
@KristofferC KristofferC mentioned this pull request Apr 13, 2023
Merged
26 tasks
@KristofferC KristofferC merged commit 99c0dad into JuliaLang:master Apr 14, 2023
KristofferC pushed a commit that referenced this pull request Apr 14, 2023
@hyrodium @KristofferC
Rename ipython_mode to numbered_prompt (#49314)
3ece193 
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
(cherry picked from commit 99c0dad)
@hyrodium hyrodium mentioned this pull request Apr 16, 2023
Open
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson left review comments

Assignees
No one assigned
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hyrodium @KristofferC @pabloferz @IanButterworth @JeffBezanson