-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename QuickerSort to ScratchQuickSort #48160
Conversation
I actually prefer @petvana, I'm curious what your objection to renaming |
I'm not a native speaker. But |
Thank you! The perspective of a non-native speaker is important to me because I want this name to make sense to non-native speaker users.
julia> @btime sort!(rand!(x); alg=QuickSort) setup=(x=rand(Int, 1000));
33.422 μs (0 allocations: 0 bytes)
julia> @btime sort!(rand!(x); alg=Base.Sort.QuickerSort(), scratch) setup=(x=rand(Int, 1000); scratch=rand(Int, 1000));
21.655 μs (0 allocations: 0 bytes)
julia> VERSION
v"1.9.0-beta2" Perhaps |
+1 for |
`ScratchQuickSort` is like `QuickSort`, but utilizes scratch space to operate faster and allow | ||
for the possibility of maintaining stability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels right
(cherry picked from commit 9707594)
From #47973 (comment) and discussion on slack.
fwiw, the term we use in sorting is "scratch space" and the (undocumented) keyword argument is named "scratch".