Fix small nits in multiversioning #47675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can add tests? 🙂 |
|
I'm not sure how I would test that we clone functions correctly when building the sysimg 😄. |
|
Build a mini sysimage and disassemble the output? |
vchuravy
approved these changes
Nov 23, 2022
51 tasks
26 tasks
|
@vchuravy, merge? |
14 tasks
vchuravy
force-pushed
the
fix-multiver
branch
from
d79503d
to
f2acf86
Compare
vchuravy
approved these changes
Dec 28, 2022
41 tasks
|
This doesn't backport cleanly, not sure if something else has to go in before this. |
|
Did we backport #43327? I see the tag, but no reference from one of the backport PRs. |
|
I think that was too old for my backport script to consider it. I will try with that one |
KristofferC
pushed a commit
that referenced
this pull request
Jan 16, 2023
(cherry picked from commit 4562cfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to the multiversioning pass had a couple small bugs.
@pchintalapudi