Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small nits in multiversioning #47675

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

gbaraldi
Copy link
Member

The recent changes to the multiversioning pass had a couple small bugs.
@pchintalapudi

@vchuravy vchuravy added the backport 1.9 Change should be backported to release-1.9 label Nov 22, 2022
@giordano
Copy link
Contributor

had a couple small bugs.

Can add tests? 🙂

@gbaraldi
Copy link
Member Author

I'm not sure how I would test that we clone functions correctly when building the sysimg 😄.

@vchuravy
Copy link
Member

Build a mini sysimage and disassemble the output?

@KristofferC
Copy link
Member

@vchuravy, merge?

@KristofferC KristofferC mentioned this pull request Dec 28, 2022
14 tasks
@KristofferC KristofferC mentioned this pull request Jan 2, 2023
41 tasks
@KristofferC KristofferC merged commit 4562cfa into JuliaLang:master Jan 5, 2023
@KristofferC
Copy link
Member

This doesn't backport cleanly, not sure if something else has to go in before this.

@vchuravy
Copy link
Member

vchuravy commented Jan 16, 2023

Did we backport #43327? I see the tag, but no reference from one of the backport PRs.

@KristofferC
Copy link
Member

I think that was too old for my backport script to consider it. I will try with that one

KristofferC pushed a commit that referenced this pull request Jan 16, 2023
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants