-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parentmodule(f, types)
should throw an error if there are multiple matching methods
#47588
base: master
Are you sure you want to change the base?
Conversation
While I doubt anyone is relying on the current (and as Jeff said, strange) behavior, it's worth noting that this is technically a breaking change. Probably fine for a minor release but we might want to do a PkgEval run just to make sure. |
0adaab0
to
f27037d
Compare
…matching methods
f27037d
to
b331a73
Compare
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
@nanosoldier |
Some of those failures will be fixed now by a PkgEval change, so let's retry on an newer version: @nanosoldier That said, re-running PkgEval shouldn't generally be necessary anymore, or at least not when there's no new changes. PkgEval already retries automatically now, so the failures are likely to just re-occur. |
Your package evaluation job has completed - no new issues were detected. A full report can be found here. |
#47548 (comment)