Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parentmodule(f, types) should throw an error if there are multiple matching methods #47588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

@brenhinkeller brenhinkeller added the error handling Handling of exceptions by Julia or the user label Nov 16, 2022
@ararslan ararslan added the needs tests Unit tests are required for this change label Nov 16, 2022
@ararslan
Copy link
Member

While I doubt anyone is relying on the current (and as Jeff said, strange) behavior, it's worth noting that this is technically a breaking change. Probably fine for a minor release but we might want to do a PkgEval run just to make sure.

@DilumAluthge DilumAluthge added the needs pkgeval Tests for all registered packages should be run with this change label Nov 16, 2022
@DilumAluthge DilumAluthge added bugfix This change fixes an existing bug minor change Marginal behavior change acceptable for a minor release labels Nov 17, 2022
@DilumAluthge
Copy link
Member Author

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@DilumAluthge
Copy link
Member Author

@nanosoldier runtests(["STREAMBenchmark", "OpenQuantumTools", "Test", "GigaSOM", "Sinograms", "Pidfile", "Books", "OteraEngine", "XGBoost", "Cambrian"])

@maleadt
Copy link
Member

maleadt commented Nov 28, 2022

Some of those failures will be fixed now by a PkgEval change, so let's retry on an newer version:

@nanosoldier runtests(["STREAMBenchmark", "OpenQuantumTools", "Test", "GigaSOM", "Sinograms", "Pidfile", "Books", "OteraEngine", "XGBoost", "Cambrian"])

That said, re-running PkgEval shouldn't generally be necessary anymore, or at least not when there's no new changes. PkgEval already retries automatically now, so the failures are likely to just re-occur.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected. A full report can be found here.

@ararslan ararslan removed the needs pkgeval Tests for all registered packages should be run with this change label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug error handling Handling of exceptions by Julia or the user minor change Marginal behavior change acceptable for a minor release needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants