fix linkage of libuv #47203
Merged
fix linkage of libuv #47203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only libjulia-internal is supposed to be linked against this, since it is a static library. Fix #47198
|
LGTM after tests pass |
gbaraldi
approved these changes
Oct 17, 2022
KristofferC
pushed a commit
that referenced
this pull request
Oct 27, 2022
37 tasks
KristofferC
pushed a commit
that referenced
this pull request
Oct 28, 2022
|
This breaks shared linking of libuv, is that supposed to work? |
|
not really supposed to work, though in theory we could list libuv twice (if sufficiently careful) and |
|
Will stick to static libs then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only libjulia-internal is supposed to be linked against this, since it is a static library.
Fix #47198
n.b.