fix --compile=all option, and some improvements for --strip-ir
#46935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
bugfix
JeffBezanson
commented
Sep 27, 2022
vtjnash
reviewed
Sep 28, 2022
vtjnash
approved these changes
Sep 28, 2022
| { | ||
| jl_array_t *found = (jl_array_t*)env; | ||
| // method definition -- compile template field | ||
| jl_array_t *allmeths = (jl_array_t*)env; | ||
| jl_method_t *m = ml->func.method; | ||
| if (m->source) { |
There was a problem hiding this comment.
Should we try to normalize on whether !source or source == jl_nothing implies the absence of source code?
There was a problem hiding this comment.
Yes sounds like a good idea.
It could, what would be a good test? Just compile a new sysimage with |
JeffBezanson
force-pushed
the
jb/compileall
branch
from
0dfdf23
to
e2d043e
Compare
JeffBezanson
force-pushed
the
jb/compileall
branch
from
e2d043e
to
1f0c2e2
Compare
37 tasks
KristofferC
added a commit
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--compile=allhas been broken for several releases. What it's supposed to do is simply compile one generic implementation (i.e. specialized for the declared argument types of a method) for each method, so that programs can run without the compiler or IR present.Fixes calling
return_typein images built with --strip-ir; we were just missing anothingcheck.Also don't bother compiling code for the type inference world when using --strip-ir.(Left this out for now in the interest of minimizing disruption.) It would be good to be able to exclude Core.Compiler entirely in that case, but it's not trivial due toreturn_type.Also make
--compileand module-level settings take precedence overforce_compilemetadata.Obviously, this could use tests --- maybe it can be tested as part of PackageCompiler?
Possible future work: remove the Method.unspecialized field, since all it does is cache the lookup of one specialization, but that lookup should only be done in slow paths.