Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shift direction of circshift! for vectors #46759

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Fix shift direction of circshift! for vectors #46759

merged 1 commit into from
Sep 27, 2022

Conversation

fredrikekre
Copy link
Member

This patch fixes the shifting direction for
circshift!(x::AbstractVector, n::Integer), which was opposite the
direction of circshift(x, n) and circshift!(y, x, n). In addition, this
patch fixes the method to also work correctly with offset arrays.
Fixes #46533.

@fredrikekre fredrikekre added the needs tests Unit tests are required for this change label Sep 14, 2022
@gbaraldi
Copy link
Member

I believe this will break some sparsearrays stuff. @Keno

@fredrikekre
Copy link
Member Author

Yea, will have to fix there too. But hopefully this isn't used much in the ecosystem yet, it has only been in 1.8.0.

@fredrikekre
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@fredrikekre fredrikekre mentioned this pull request Sep 15, 2022
Merged
fredrikekre added a commit that referenced this pull request Sep 16, 2022
@fredrikekre
Update SparseArrays dependency
b78f7c5 
This patch updates SparseArrays. In particular it contains
JuliaSparse/SparseArrays.jl#260 which is
necessary to make progress in #46759.
fredrikekre added a commit that referenced this pull request Sep 16, 2022
@fredrikekre
Update SparseArrays dependency
8eea138 
This patch updates SparseArrays. In particular it contains
JuliaSparse/SparseArrays.jl#260 which is
necessary to make progress in #46759.

All changes:
```
4fb8f0e Fix direction of circshift (#260)
ead48fe Fix `vcat` of sparse vectors with numbers (#253)
d88be9f decrement should always return a vector (#241)
dfcc48a change order of arguments in fkeep, fix bug with fixed elements (#240)
43b4d01 Sparse matrix/vectors with fixed sparsity pattern. (#201)
```
fredrikekre added a commit that referenced this pull request Sep 16, 2022
@fredrikekre
Update SparseArrays dependency
e06049e 
This patch updates SparseArrays. In particular it contains
JuliaSparse/SparseArrays.jl#260 which is
necessary to make progress in #46759.

All changes:
 - Fix direction of circshift (JuliaSparse/SparseArrays.jl#260)
 - Fix `vcat` of sparse vectors with numbers (JuliaSparse/SparseArrays.jl#253)
 - decrement should always return a vector (JuliaSparse/SparseArrays.jl#241)
 - change order of arguments in fkeep, fix bug with fixed elements (JuliaSparse/SparseArrays.jl#240)
 - Sparse matrix/vectors with fixed sparsity pattern. (JuliaSparse/SparseArrays.jl#201)
@fredrikekre fredrikekre mentioned this pull request Sep 16, 2022
Merged
@fredrikekre fredrikekre added the backport 1.8 Change should be backported to release-1.8 label Sep 16, 2022
fredrikekre added a commit that referenced this pull request Sep 16, 2022
@fredrikekre
Update SparseArrays dependency
4a28946 
This patch updates SparseArrays. In particular it contains
JuliaSparse/SparseArrays.jl#260 which is
necessary to make progress in #46759.

All changes:
 - Remove fkeep! from the documentation (JuliaSparse/SparseArrays.jl#261)
 - Fix direction of circshift (JuliaSparse/SparseArrays.jl#260)
 - Fix `vcat` of sparse vectors with numbers (JuliaSparse/SparseArrays.jl#253)
 - decrement should always return a vector (JuliaSparse/SparseArrays.jl#241)
 - change order of arguments in fkeep, fix bug with fixed elements (JuliaSparse/SparseArrays.jl#240)
 - Sparse matrix/vectors with fixed sparsity pattern. (JuliaSparse/SparseArrays.jl#201)
fredrikekre added a commit that referenced this pull request Sep 22, 2022
@fredrikekre
Update SparseArrays dependency
8eb780a 
This patch updates SparseArrays. In particular it contains
JuliaSparse/SparseArrays.jl#260 which is
necessary to make progress in #46759.

All changes:
 - Fix ambiguities with Base. (JuliaSparse/SparseArrays.jl#268)
 - add == for vectors (JuliaSparse/SparseArrays.jl#248)
 - add undef initializers (JuliaSparse/SparseArrays.jl#263)
 - Make sure reductions benefit from sparsity (JuliaSparse/SparseArrays.jl#244)
 - Remove fkeep! from the documentation (JuliaSparse/SparseArrays.jl#261)
 - Fix direction of circshift (JuliaSparse/SparseArrays.jl#260)
 - Fix `vcat` of sparse vectors with numbers (JuliaSparse/SparseArrays.jl#253)
 - decrement should always return a vector (JuliaSparse/SparseArrays.jl#241)
 - change order of arguments in fkeep, fix bug with fixed elements (JuliaSparse/SparseArrays.jl#240)
 - Sparse matrix/vectors with fixed sparsity pattern. (JuliaSparse/SparseArrays.jl#201)
fredrikekre added a commit that referenced this pull request Sep 27, 2022
@fredrikekre
Update SparseArrays dependency (#46790)
6fdcfd4 
This patch updates SparseArrays. In particular it contains
JuliaSparse/SparseArrays.jl#260 which is
necessary to make progress in #46759.

All changes:
 - Fix ambiguities with Base. (JuliaSparse/SparseArrays.jl#268)
 - add == for vectors (JuliaSparse/SparseArrays.jl#248)
 - add undef initializers (JuliaSparse/SparseArrays.jl#263)
 - Make sure reductions benefit from sparsity (JuliaSparse/SparseArrays.jl#244)
 - Remove fkeep! from the documentation (JuliaSparse/SparseArrays.jl#261)
 - Fix direction of circshift (JuliaSparse/SparseArrays.jl#260)
 - Fix `vcat` of sparse vectors with numbers (JuliaSparse/SparseArrays.jl#253)
 - decrement should always return a vector (JuliaSparse/SparseArrays.jl#241)
 - change order of arguments in fkeep, fix bug with fixed elements (JuliaSparse/SparseArrays.jl#240)
 - Sparse matrix/vectors with fixed sparsity pattern. (JuliaSparse/SparseArrays.jl#201)
@fredrikekre
Fix shift direction of circshift! for vectors
75b2410 
This patch fixes the shifting direction for
circshift!(x::AbstractVector, n::Integer), which was opposite the
direction of circshift(x, n) and circshift!(y, x, n). In addition, this
patch fixes the method to also work correctly with offset arrays.
Fixes #46533.
@fredrikekre fredrikekre removed the needs tests Unit tests are required for this change label Sep 27, 2022
@oscardssmith oscardssmith modified the milestones: 1.8, 1.9 Sep 27, 2022
@fredrikekre fredrikekre merged commit f1c4d54 into master Sep 27, 2022
@fredrikekre fredrikekre deleted the fe/circshift branch September 27, 2022 19:15
KristofferC pushed a commit that referenced this pull request Sep 30, 2022
@fredrikekre
Fix shift direction of circshift! for vectors (#46759)
e2c1b96 
This patch fixes the shifting direction for
circshift!(x::AbstractVector, n::Integer), which was opposite the
direction of circshift(x, n) and circshift!(y, x, n). In addition, this
patch fixes the method to also work correctly with offset arrays.
Fixes #46533.

(cherry picked from commit f1c4d54)
@KristofferC KristofferC mentioned this pull request Sep 30, 2022
Merged
37 tasks
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@fredrikekre @KristofferC
Fix shift direction of circshift! for vectors (#46759)
5d30157 
This patch fixes the shifting direction for
circshift!(x::AbstractVector, n::Integer), which was opposite the
direction of circshift(x, n) and circshift!(y, x, n). In addition, this
patch fixes the method to also work correctly with offset arrays.
Fixes #46533.

(cherry picked from commit f1c4d54)
@gbaraldi gbaraldi mentioned this pull request Nov 6, 2022
Closed
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

circshift!(x, n) and circshift(x, n) shift in different directions
5 participants
@fredrikekre @gbaraldi @nanosoldier @KristofferC @oscardssmith