-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Vector with BitSet in optimization passes #46587
Conversation
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@nanosoldier |
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
While the performance improvements are negligible, it seems plausible that the previous approach could result in quadratic runtime in certain cases due to julia/base/compiler/ssair/passes.jl Lines 78 to 80 in e1139e7
I think this change is worth making. Whitespace is broken due to old master. |
Codecov Report
@@ Coverage Diff @@
## master #46587 +/- ##
==========================================
+ Coverage 93.63% 93.69% +0.05%
==========================================
Files 380 387 +7
Lines 85981 86056 +75
==========================================
+ Hits 80508 80628 +120
+ Misses 5473 5428 -45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bump (c.f. #46679 (comment)). There doesn't seem to be much practical performance impact of this PR, but it is a theoretical improvement and more importantly, it reduces Core's dependency on Sort, which is needed for #46679. |
Rerunning benchmarks after rebase |
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
I'm merging this today sans objections. |
I was unable to determine why this sorting operation is needed. I tracked it down to 8af40ea so perhaps Keno (waiting for CI to pass to ping) knows if there is a reason to keep this?
Closes #46507