-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fix intersect error reported in #41096 #46350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use `merge_env` to track valid env change.
Wow, this is great. Seems right to me, and other than that I go by the tests. I see one test was changed, but it's ok because the results are more conservative, so I'm happy with that. Thank you, this code is very tricky! @nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
MWE
This PR makes sure
env
is restored between every 2 adjacentintersect
s duringintersect_all
.The valid env changes are tracked (and merged) with a new function
merge_env
.Not sure this is the correct direction to fix the problem.
Close #41096.
Edit: looks like this PR also fixes #43082.