Fix ordering of headers so #define _GNU_SOURCE comes first
#46183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
building
32 tasks
35 tasks
|
This should be merged right? @giordano |
|
Yes, looks good to me |
KristofferC
pushed a commit
that referenced
this pull request
Aug 29, 2022
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> (cherry picked from commit 3b81696)
DilumAluthge
removed
the
merge me
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling Julia under Guix fails for any version beyond commit c5cb029 which introduced an include statement before
#define _GNU_SOURCE. The compilation would fail to find symbolsdlfcn.has feature test macros in GCC must come before any the inclusion of any system header file. See https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html