Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profile] threads here is wrong to use nthreads #45547

Merged
merged 2 commits into from
Jun 2, 2022
Merged

[Profile] threads here is wrong to use nthreads #45547

merged 2 commits into from
Jun 2, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jun 1, 2022

Since the data argument possibly does not come from the current
configuration, we should not use nthreads here either to filter out
possibly significant data.

@vtjnash
[Profile] threads here is wrong to use nthreads
731ad5e 
Since the `data` argument possibly does not come from the current
configuration, we should not use `nthreads` here either to filter out
possibly significant data.
@vtjnash vtjnash added the backport 1.8 Change should be backported to release-1.8 label Jun 1, 2022
IanButterworth
IanButterworth approved these changes Jun 1, 2022
View reviewed changes
stdlib/Profile/src/Profile.jl Outdated Show resolved Hide resolved
@vtjnash @IanButterworth
Update stdlib/Profile/src/Profile.jl
07ec768 
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Jun 2, 2022
@vtjnash vtjnash merged commit b46c14e into master Jun 2, 2022
@vtjnash vtjnash deleted the jn/Profile-nthreads branch June 2, 2022 14:49
@KristofferC KristofferC mentioned this pull request Jun 7, 2022
Merged
36 tasks
KristofferC pushed a commit that referenced this pull request Jun 8, 2022
@vtjnash
[Profile] threads here is wrong to use nthreads (#45547)
087ba27 
Since the `data` argument possibly does not come from the current
configuration, we should not use `nthreads` here either to filter out
possibly significant data.

(cherry picked from commit b46c14e)
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Jun 10, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @IanButterworth @giordano @KristofferC