csl.mk: use libgcc_s 1.1 on aarch64-darwin #45504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes |
giordano
added
building
|
Might this be considered for a 1.8 backport? After #45380 is backported (it has been marked for backport), this patch will be the only one needed for a full build of julia 1.8 from source on macOS. 🥳 |
KristofferC
pushed a commit
that referenced
this pull request
Jun 7, 2022
(cherry picked from commit 6f8860c)
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR at #44487 added correct support for
libgcc_s.1.1.dylibon macOS on aarch64. But this missed the equivalent indeps/csl.mk, which is needed when runningmake install-csl(which we do in Homebrew).In the current situation, the compiler does not correctly install
libgcc_s.1.1.dylib, andjuliafails to run once installed.