Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update p7zip to 17.04 #45435

Merged
merged 4 commits into from
May 24, 2022
Merged

Update p7zip to 17.04 #45435

merged 4 commits into from
May 24, 2022

Conversation

fxcoudert
Copy link
Contributor

This is not ready to merge, it's waiting on the new version being merged: JuliaRegistries/General#60895

The build from source works, I tested it locally on aarch64-darwin.

@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels May 24, 2022
@KristofferC
Copy link
Member

KristofferC commented May 24, 2022

The version in https://github.com/JuliaBinaryWrappers/p7zip_jll.jl/releases/ is 17.4 and not 17.04.

@KristofferC KristofferC marked this pull request as ready for review May 24, 2022 12:51
@KristofferC
Copy link
Member

I pushed a commit here that seems to fix the BB-config as well.

@fxcoudert
Copy link
Contributor Author

fxcoudert commented May 24, 2022

One test failure in freebsd64, which we have already seen in another unrelated PR on linuxaarch64: #45380

I think it's a fluke, and the PR is ready for merging.

@KristofferC KristofferC merged commit 86f5501 into JuliaLang:master May 24, 2022
KristofferC pushed a commit that referenced this pull request May 24, 2022
Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
(cherry picked from commit 86f5501)
KristofferC pushed a commit that referenced this pull request May 24, 2022
Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
(cherry picked from commit 86f5501)
@fxcoudert fxcoudert deleted the p7zip branch May 24, 2022 16:39
@mbauman mbauman mentioned this pull request May 24, 2022
67 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
KristofferC pushed a commit that referenced this pull request Jul 4, 2022
Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
(cherry picked from commit 86f5501)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 6, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
(cherry picked from commit 86f5501)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
(cherry picked from commit 86f5501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants