Skip to content

make mbedTLS warnings non fatal #45419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

make mbedTLS warnings non fatal #45419

merged 1 commit into from
May 26, 2022

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented May 22, 2022 •
edited
Loading

Disable -Werror on mbedTLS 2.X dependency when building from source with recent compilers (gcc 11.2.0 is default on ubuntu 22.04 LTS), which is probably too strict:

[...]/deps/srccache/mbedtls-2.24.0/library/ssl_tls.c:1724:41: error: argument 2 of type ‘unsigned char[36]’ with mismatched bound [-Werror=array-parameter=]
 1724 |                           unsigned char hash[36],
[...]

@t-bltg t-bltg mentioned this pull request May 23, 2022
Closed
@giordano giordano added the building Build system, or building Julia or its dependencies label May 26, 2022
giordano
giordano approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're usually ok with not making warnings errors by default, which is annoying when you start using new compilers with stricter warnings. I'll merge in a couple of days if there are no objections

@vtjnash vtjnash merged commit 4f9483c into JuliaLang:master May 26, 2022
@t-bltg t-bltg deleted the patch-2 branch May 26, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-bltg @vtjnash @giordano