Profile.getdict!: Revert drive-by change-of-behavior in performance patch #45403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull request JuliaLang#43816 is supposed to be a performance improvement (only), but also changes behaviour: it's now possible for `getdict!(dict, data)` to return with some elements of `data` not a valid key in `dict`. Maybe this is a desired improvement now that `data` also contains metadata about taskid and threadid, but it's certainly breaking at least one registered package (which I reported as JuliaLang#45361). I propose we keep the performance improvement but revert the change in behaviour. We can then discuss the behaviour's merit in a separate pull request if desired, without the time pressure of the imminent v1.8 release.
IanButterworth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request #43816 is supposed to be a performance improvement (only), but also changes behaviour: it's now possible for
getdict!(dict, data)to return with some elements ofdatanot a valid key indict.Maybe this is a desired improvement now that
dataalso contains metadata about taskid and threadid, but it's certainly breaking at least one registered package (which I reported as #45361).I propose we keep the performance improvement but revert the change in behaviour. We can then discuss the behaviour's merit in a separate pull request if desired, without the time pressure of the imminent v1.8 release.